Re: [HACKERS] Patch: show relation and tuple infos of a lock to acquire

[Christian Kruse]

Hi,

On 10/03/14 14:59, Robert Haas wrote:
> On Mon, Mar 10, 2014 at 7:44 AM, Christian Kruse
> <christ...@2ndquadrant.com> wrote:
> > [ response to review ]
> 
> This response seems to have made no mention of point #7 from Amit's
> review, which seems to me to be a rather important one.

Just didn't notice it because the previous point was the same. NULL'd
the tuple there, too:

--- a/src/backend/executor/execUtils.c
+++ b/src/backend/executor/execUtils.c
@@ -1307,7 +1307,7 @@ retry:
                if (TransactionIdIsValid(xwait))
                {
                        index_endscan(index_scan);
-                       XactLockTableWait(xwait);
+                       XactLockTableWaitWithInfo(heap, NULL, xwait);
                        goto retry;
                }

Best regards,

-- 
 Christian Kruse               http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgpkcb2npz9m2.pgp
Description: PGP signature