On Fri, Mar 21, 2014 at 12:24 PM, MauMau <maumau...@gmail.com> wrote: > From: "Amit Kapila" <amit.kapil...@gmail.com> >> If create_tablespace_directories() needs to handle with directory both on >> Windows/Linux, then shouldn't it be a runtime check as in your first >> version rather than compile time check? >> Also isn't that the reason why destroy_tablespace_directories() have >> similar >> check? > > > I see..., and you are correct. The first version of my patch should be the > right fix. It seems that my head went somewhere when I submitted the second > revision. > > What should I do? Should I re-submit the first revision as the latest fifth > revision and link the email from the CommitFest newest entry?
The comments in your first version needs to be improved, as there you just mentioned a Windows specific comment: + /* On Windows, lstat() I think you can change comments (make it somewhat similar to destroy_tablespace_directories) and then submit it as a new version. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
