On 2014-04-02 15:03:47 -0400, Tom Lane wrote: > Andres Freund <and...@2ndquadrant.com> writes: > > On 2014-04-02 14:36:28 -0400, Tom Lane wrote: > >> Well, in any case, people very seldom check to see if any buildfarm > >> members are producing compiler warnings. You need the build to actually > >> go red to get anyone's attention reliably. > > > Yea, we'd need to be able to turn on -Werror if it's going to have any > > effect. I don't think our configure currently copes with that > > unfortunately... > > I'm pretty sure you can set CFLAGS from the buildfarm configuration > options --- see the animals that are building with -DCLOBBER_CACHE_ALWAYS.
The problem is rather that configure dies somewhere when CFLAGS includes -Werror. Not very nice imo. > > I just tried it on clang. It builds clean with -Wc11-extensions except > > warning about _Static_assert(). That's possibly fixable with some > > autoconf trickery. > > Ah. That sounds promising. What clang version is that? It's debian's clang-3.5, which is built from trunk IIUC: 1:3.5~svn201651-1 I have some patches that fix the configure tests to properly use -Werror, but I am too tired to check their validity now. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
