On Wed, Apr 2, 2014 at 1:41 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Mar 31, 2014 at 7:08 PM, Yugo Nagata <nag...@sraoss.co.jp> wrote: >> Hi Amit Kapila, >> >> Thank you for your reviewing. I updated the patch to v5. > > I have checked the latest version and found few minor improvements that > are required: > > 1. > ! if (!missing_ok) > ! ereport(ERROR, > ! (errcode(ERRCODE_UNDEFINED_OBJECT), > ! errmsg("type \"%s\" does not exist", > ! TypeNameToString(typeName)), > ! parser_errposition(NULL, typeName->location))); > > pfree(buf.data); seems to be missing in error cases.
Eh, surely this is being done in some memory context that an error will reset anyway? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers