"MauMau" <maumau...@gmail.com> writes: > [ pg_ctl_eventsrc_v6.patch ]
I looked at this patch a bit. As a non-Windows person I have no intention of being the committer, since I can't test the Windows-specific changes. However, I do want to object to the business about having pg_ctl use "postgres -C" to try to determine the event source name to use. The code that you repurposed was okay for its original use, namely finding out where a config directory would point the data directory to, but I don't think it's up to snuff for identifying the value of event_source that a running server is using. The actual value might have been set from a command line option for instance. Moreover, the whole thing seems rather circular since what pg_ctl wants the event source name for is to report errors. What if it fails to get the event source name, or needs to report an error before the (rather late) point at which it even tries to get it? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers