Hi, I'm reading xlog.c, and I noticed a comment of do_pg_abort_backup is typo.
... 10247 * NB: This is only for aborting a non-exclusive backup that doesn't write 10248 * backup_label. A backup started with pg_stop_backup() needs to be finished 10249 * with pg_stop_backup(). ... I think "A backup started with pg_stop_backup()" should be "A backup started with pg_start_backup()". This is a bug about source comment, so it's not big problem. But I want to fix the comment. See attached patch. regards, -------------- Tomonari Katsumata
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 0b4a5f6..3551d94 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -10245,7 +10245,7 @@ do_pg_stop_backup(char *labelfile, bool waitforarchive, TimeLineID *stoptli_p) * an error handler. * * NB: This is only for aborting a non-exclusive backup that doesn't write - * backup_label. A backup started with pg_stop_backup() needs to be finished + * backup_label. A backup started with pg_start_backup() needs to be finished * with pg_stop_backup(). */ void
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
