rebased
2014-04-29 7:43 GMT+04:00 Michael Paquier <[email protected]>:
> On Tue, Apr 29, 2014 at 12:37 PM, Sergey Muraviov
> <[email protected]> wrote:
> > 2014-04-29 5:52 GMT+04:00 Peter Eisentraut <[email protected]>:
> >
> >> Please fix this compiler warning. I think it came from this patch.
> >> print.c: In function 'print_aligned_vertical':
> >> print.c:1354:10: error: pointer targets in passing argument 1 of
> >> 'strlen_max_width' differ in signedness [-Werror=pointer-sign]
> >> encoding);
> >> ^
> >> print.c:126:12: note: expected 'unsigned char *' but argument is of type
> >> 'char *'
> >> static int strlen_max_width(unsigned char *str, int *target_width, int
> >> encoding);
> >> ^
> > fixed
> Your patch has been committed by Greg not so long ago, you should send
> for this warning a patch rebased on the latest master branch commit :)
> --
> Michael
>
--
Best regards,
Sergey Muraviov
diff --git a/src/bin/psql/print.c b/src/bin/psql/print.c
index 0ebffff..b2f56a3 100644
--- a/src/bin/psql/print.c
+++ b/src/bin/psql/print.c
@@ -1350,8 +1350,7 @@ print_aligned_vertical(const printTableContent *cont, FILE *fout)
{
int swidth, twidth = hwidth + 1;
fputs(hline? format->header_nl_left: " ", fout);
- strlen_max_width((char *) hlineptr[hline].ptr, &twidth,
- encoding);
+ strlen_max_width(hlineptr[hline].ptr, &twidth, encoding);
fprintf(fout, "%-s", hlineptr[hline].ptr);
swidth = hwidth - twidth;
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
