On Thu, May 15, 2014 at 06:08:47PM -0700, David G Johnston wrote: > Some errors and suggestions - my apologizes for the format as I do not have > a proper patching routine setup. > > Patch Review - Top to Bottom (mostly, I think...)
I have made your suggested adjustments in the attached applied patch. > Add ROWS FROM() syntax to allow horizontal concatenation of set-returning > functions in the FROM-clause (Andrew Gierth) > -> Maybe a note about using this to avoid least-common-multiple expansion? Sorry, I do not understand this. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. +
diff --git a/doc/src/sgml/release-9.4.sgml b/doc/src/sgml/release-9.4.sgml new file mode 100644 index 91a586f..41256b7 *** a/doc/src/sgml/release-9.4.sgml --- b/doc/src/sgml/release-9.4.sgml *************** *** 89,95 **** linkend="functions-formatting-table"><function>to_timestamp()</></link> and <function>to_date()</> format strings to consume a corresponding number of characters in the input string (whitespace or not), then ! conditionally additional adjacent whitespace if not in <literal>FX</> mode (Jeevan Chalke) </para> --- 89,95 ---- linkend="functions-formatting-table"><function>to_timestamp()</></link> and <function>to_date()</> format strings to consume a corresponding number of characters in the input string (whitespace or not), then ! conditionally consume adjacent whitespace if not in <literal>FX</> mode (Jeevan Chalke) </para> *************** *** 98,104 **** format string behaved like a single whitespace character and consumed all adjacent whitespace in the input string. For example, previously format string space-space-space would consume only the first space in ! ' 12', while it will not consume all three characters. </para> </listitem> --- 98,104 ---- format string behaved like a single whitespace character and consumed all adjacent whitespace in the input string. For example, previously format string space-space-space would consume only the first space in ! ' 12', while it will now consume all three characters. </para> </listitem> *************** *** 122,128 **** </para> <para> ! Previously empty arrays were returned as one-dimensional empty arrays whose text representation looked the same as zero-dimensional arrays (<literal>{}</>). <application>intarray</>'s behavior in this area now matches the built-in array operators. --- 122,128 ---- </para> <para> ! Previously, empty arrays were returned as one-dimensional empty arrays whose text representation looked the same as zero-dimensional arrays (<literal>{}</>). <application>intarray</>'s behavior in this area now matches the built-in array operators. *************** *** 131,139 **** <listitem> <para> ! NULL <link linkend="xfunc-sql-variadic-functions"><literal>VARIADIC</></link> ! function arguments are now disallowed (Pavel Stehule) </para> <para> --- 131,139 ---- <listitem> <para> ! Disallow NULL <link linkend="xfunc-sql-variadic-functions"><literal>VARIADIC</></link> ! function arguments (Pavel Stehule) </para> <para> *************** *** 300,306 **** <listitem> <para> ! <command>DISCARD ALL</> now also discards the state of sequences. </para> </listitem> --- 300,306 ---- <listitem> <para> ! <command>DISCARD ALL</> now also discards sequence state. </para> </listitem> *************** *** 366,372 **** <listitem> <para> ! During immediate shutdown, send uncatchable termination signals to child processes that have not already shutdown (MauMau, Álvaro Herrera) </para> --- 366,372 ---- <listitem> <para> ! During immediate shutdown send uncatchable termination signals to child processes that have not already shutdown (MauMau, Álvaro Herrera) </para> *************** *** 740,746 **** <para> In contrast ! to <link linkend="guc-local-preload-libraries"><varname>local_preload_libraries</></link>, this parameter can load any shared library, not just those in the <filename>$libdir/plugins</> directory. </para> --- 740,746 ---- <para> In contrast ! to <link linkend="guc-local-preload-libraries"><varname>local_preload_libraries</></link> this parameter can load any shared library, not just those in the <filename>$libdir/plugins</> directory. </para> *************** *** 789,796 **** <listitem> <para> Have Windows <acronym>ASCII</>-encoded databases and server process ! (e.g. <link linkend="app-postmaster">postmaster) emit messages ! in the <envar>LC_CTYPE</></link>-defined language (Alexander Law, Noah Misch) </para> --- 789,796 ---- <listitem> <para> Have Windows <acronym>ASCII</>-encoded databases and server process ! (e.g. <link linkend="app-postmaster">postmaster</>) emit messages ! in the <envar>LC_CTYPE</>-defined language (Alexander Law, Noah Misch) </para> *************** *** 994,1000 **** <listitem> <para> Add <link linkend="queries-tablefunctions"><literal>WITH ! ORDINALITY</></link> syntax which numbers rows returned from <literal>FROM</>-clause functions (Andrew Gierth, David Fetter) </para> --- 994,1000 ---- <listitem> <para> Add <link linkend="queries-tablefunctions"><literal>WITH ! ORDINALITY</></link> syntax to number rows returned from <literal>FROM</>-clause functions (Andrew Gierth, David Fetter) </para> *************** *** 1042,1048 **** Add <command>FORCE NULL</> option to <link linkend="SQL-COPY"><command>COPY FROM</></link> which causes quoted strings matching the null string to be converted to NULL in ! in <literal>CSV</> mode (Ian Barwick, Michael Paquier) </para> <para> --- 1042,1048 ---- Add <command>FORCE NULL</> option to <link linkend="SQL-COPY"><command>COPY FROM</></link> which causes quoted strings matching the null string to be converted to NULL in ! <literal>CSV</> mode (Ian Barwick, Michael Paquier) </para> <para> *************** *** 1178,1184 **** <listitem> <para> ! Improve the internal definition of system relations (Andres Freund, Robert Haas) </para> --- 1178,1184 ---- <listitem> <para> ! Improve how system-level relations are designated (Andres Freund, Robert Haas) </para>
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers