On Thu, May 22, 2014 at 12:18 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Thu, May 22, 2014 at 12:44 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> Hi all, >> >> As written in subject, replication protocol documentation lacks >> details about logical slots in CREATE_REPLICATION_SLOT command: >> http://www.postgresql.org/docs/devel/static/protocol-replication.html >> Attached is a patch correcting that. > An additional thing I noticed: START_REPLICATION does not mention that > it is possible to specify options for the output plugin. All the fixes > are included in the patch attached.
Thanks, this looks good. But shouldn't the bit about output plugin options mention say something like: ( option_name option_argument [, ...] ) ...instead of just: ( option [, ...] ) ? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
