On Fri, Jun 13, 2014 at 8:39 PM, Andres Freund <and...@2ndquadrant.com> wrote: > On 2014-06-13 14:37:33 +0300, Heikki Linnakangas wrote: >> As part of the WAL-format changing patch I've been working on, I changed the >> signature of the rm_desc function from: >> >> void (*rm_desc) (StringInfo buf, uint8 xl_info, char *rec); >> void (*rm_desc) (StringInfo buf, XLogRecord *record); >> >> The WAL-format patch needed that because it added more functions/macros for >> working with XLogRecords, also used by rm_desc routines, but it seems like a >> sensible change anyway. IMHO it was always a bit strange that rm_desc was >> passed the info field and record payload separately.
+1, too. -/* #define WAL_DEBUG */ +#define WAL_DEBUG ISTM you just forgot to exclude this change from the patch. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
