On 06/18/2014 11:50 AM, Kevin Grittner wrote: > The first thing is that I don't think a delay between the BEGIN and > the SELECT should cause a timeout to trigger, but more importantly > there should not be two ERROR responses to one SELECT statement.
I do think a delay between BEGIN and SELECT should trigger the timeout. There are plenty of badly-written applications which "auto-begin", that is, they issue a "BEGIN;" immediately after every "COMMIT;" whether or not there's any additional work to do. This is a major source of IIT and the timeout should not ignore it. > I'm inclined to abandon the ERROR approach as not worth the effort > and fragility, and focus on v1 of the patch. If we can't get to > consensus on that, I think that this patch should be flagged > "Returned with Feedback", noting that any follow-up version > requires some way to deal with the issues raised regarding multiple > ERROR messages. +1 -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
