Andres Freund wrote: > On 2014-06-20 16:50:15 -0400, Alvaro Herrera wrote:
> > I think most, if not all, the unique indexes declared are part of a > > syscache. I don't think we allow those to be null, so in effect those > > columns are already not nullable. > > Non-unique indexes in indexing.h > > already bear a standard comment that they are not used for syscache. > > The only exception was added recently in f01d1ae3a104019: > > DECLARE_INDEX(pg_class_tblspc_relfilenode_index, 3455, on pg_class using > > btree(reltablespace oid_ops, relfilenode oid_ops)); > > There's no NULLs in here. It can have duplicates, but in that it's far > from alone. I'm only saying it's missing the /* this index is not unique */ comment that all other DECLARE_INDEX() lines have. Sorry I wasn't clear. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
