Abhijit Menon-Sen <a...@2ndquadrant.com> writes:
> I had another look now, and I think removing the comment is fine. It
> actually made no sense to me in context, so I went digging a little.
> ...
> Note that the first argument was actually NULL, so the comment made
> sense when it was written. But the code was subsequently changed to
> pass in arg->elm by the following commit:
> commit 09130e5867d49c72ef0f11bef30c5385d83bf194
> Author: Tom Lane <t...@sss.pgh.pa.us>
> Date: Mon Oct 11 22:16:40 2010 -0400
> Fix plpython so that it again honors typmod while assigning to tuple
> fields.
> This was broken in 9.0 while improving plpython's conversion behavior
> for
> bytea and boolean. Per bug report from maizi.
> The comment should have been removed at the same time. So I don't think
> there's a problem here.
Yeah, you're right: the comment is referring to the struct PLyTypeInfo *
argument, which isn't there at all anymore. Mea culpa --- that's the same
sort of failure-to-update-nearby-comments thinko that I regularly mutter
about other people making :-(
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
