On 2014-06-29 12:20:02 -0400, Tom Lane wrote: > I wrote: > > BTW, it sure looks like the part of ACX_PTHREAD beginning with > > # Various other checks: > > if test "x$acx_pthread_ok" = xyes; then > > (lines 163..210 in HEAD's acx_pthread.m4) is dead code. > > On closer inspection, this has been broken since commit > e48322a6d6cfce1ec52ab303441df329ddbc04d1, which is just barely short of > its tenth birthday. The reason we've not noticed is that Postgres makes > no use of PTHREAD_CREATE_JOINABLE, nor of PTHREAD_CC, nor of HAVE_PTHREAD, > nor of the success/failure options for ACX_PTHREAD. > > I'm tempted to just rip out all the useless code rather than fix the > logic bug as such. OTOH, that might complicate updating to more recent > versions of the original Autoconf macro. On the third hand, we've not > bothered to do that in ten years either.
Rip it out, maye leaving a comment inplace like /* upstream tests for stuff we don't need here */ in its place. Since there have been a number of changes to the file, one large missing hunk shouldn't make the task of syncing measurably more difficult. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
