On 2014-07-03 21:27:53 +0900, Fujii Masao wrote: > > Add drawing random integers with a Gaussian or truncated exponentional > > distributions to pgbench. > > > > Test variants with these distributions are also provided and triggered > > with options "--gaussian=..." and "--exponential=...". > > IIRC we've not reached consensus about whether we should support > such options in pgbench. Several hackers disagreed to support them.
Yea. I certainly disagree with the patch in it's current state because it copies the same 15 lines several times with a two word difference. Independent of whether we want those options, I don't think that's going to fly. > OTOH, we've almost reached the consensus that supporting gaussian > and exponential options in \setrandom. So I think that you should > separate those two features into two patches, and we should apply > the \setrandom one first. Then we can discuss whether the other patch > should be applied or not. Sounds like a good plan. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
