On Thu, Jun 19, 2014 at 4:13 PM, MauMau <maumau...@gmail.com> wrote:
> From: "Michael Paquier" <michael.paqu...@gmail.com>
>
>> You are right, I only though about the MS scripts when working on this
>> patch. Updated patch for a complete cleanup is attached (note I
>> updated manually ./configure for test purposes and did not re-run
>> autoconf).
>
>
> I marked this patch as ready for committer. I confirmed:
I'm pretty sure this is not ready for commiter due to:
> * The binaries can be built with MSVC 2008 Express. I didn't try to build
> on MinGW.
Somebody needs to test it on mingw first :)
That should be an easy test for someone who has a mingw install
around, so better leave it at "needs review" so more people see it and
can run those tests.
> * The regression tests pass ("vcregress check").
>
> However, I wonder if some DLL entries in dlls[] in
> src/interfaces/libpq/win32.c should be removed. winsock.dll should
> definitely be removed, because it is for 16-bit applications. I don't know
> about the rest. Especially, wsock32n.dll and mswsock.dll may also be
> obsolete libraries from their names. Could you look into this and revise
> the patch if possible? But I don't mind if you do so.
I'm with michael about the "scaryness" of touching this. Also, it is
definitely a separate patch if we do...
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
