Magnus Hagander <mag...@hagander.net> writes: > On Fri, Jul 25, 2014 at 7:15 PM, Alexey Klyukin <al...@hintbits.com> wrote: >> On Fri, Jul 25, 2014 at 6:34 PM, Magnus Hagander <mag...@hagander.net> >>> Why keep looping once you've found a match? When you set result=true >>> you should break; from the loop I think. Not necessarily for >>> performance, but there might be something about a different extension >>> we can't parse for example, no need to fail in that case.
>> The for loop header is for (i = 0; i < alt_names_total && !result; i++), so >> the loop >> should terminate right when the result becomes true, which happens if the >> pg_strcasecmp >> finds a match between the given dNSName and the name supplied by the client. > oh, ha. So yeah, that was too quick to count as a review - clearly :) FWIW, I find that type of loop coding to be extremely poor style, precisely because it's not too readable. A break in the loop body is *far* more obvious to the reader. (Not to mention that it doesn't add overhead to the loop on iterations where you can't break.) regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers