On Fri, Aug 8, 2014 at 12:56 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Fujii Masao wrote: >> Hi, >> >> We can specify the unit when setting autovacuum_vacuum_cost_delay >> GUC as follows. >> >> ALTER SYSTEM SET autovacuum_vacuum_cost_delay TO '80ms'; >> >> OTOH we cannot specify the unit when setting autovacuum_vacuum_cost_delay >> as storage parameter as follows. >> >> CREATE TABLE test (col1 int) WITH (autovacuum_vacuum_cost_delay = >> '80ms'); >> ERROR: invalid value for integer option >> "autovacuum_vacuum_cost_delay": 80ms >> >> This is not user-friendly. > > No disagreement here. > >> I'd like to propose the attached patch which >> introduces the infrastructure which allows us to specify the unit when >> setting INTEGER storage parameter like autovacuum_vacuum_cost_delay. >> Comment? Review? > > Hm, what's with the parse_int signature change and the hintmsg thing? > Is it just me or the patch is incomplete?
Sorry, probably I failed to see your point. You mean that the signature of parse_int needs to be changed so that it includes the hintmsg as the argument? If yes, there is no problem. Both signature and function body of parse_int has already included the hingmsg as the argument so far. Am I missing something? Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
