On Tue, Aug 19, 2014 at 6:03 PM, Andres Freund <and...@2ndquadrant.com> wrote: > On 2014-08-19 18:02:32 +0900, Fujii Masao wrote: >> On Tue, Aug 19, 2014 at 5:52 PM, Andres Freund <and...@2ndquadrant.com> >> wrote: >> > On 2014-08-18 14:38:06 +0900, Michael Paquier wrote: >> >> - IDENTIFY_SYSTEM checks were incorrect (even in HEAD). The following >> >> check was done but in 9.4 this command returns 4 fields: >> >> (PQntuples(res) != 1 || PQnfields(res) < 3) >> > >> > Which is correct. We don't want to error out in the case where 3 columns >> > are returned because that'd unnecessarily break compatibility with < >> > 9.4. Previously that check was != 3... >> > >> > This isn't a bug. >> >> Okay, I understood why you didn't update those codes. >> >> Since we don't allow replication between different major versions, >> it's better to apply this change at least into libpqwalreceiver.c. Thought? > > We'd discussed that we'd rather keep it consistent. It also results in a > more explanatory error message lateron.
Hmm... okay, will revert the commit. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
