On Wed, Aug 20, 2014 at 12:12 PM, Dilip kumar <dilip.ku...@huawei.com> wrote: > > I have reviewed the patch and did not find any major comments.
Thanks for the review. > There are some comments I would like to share with you > > > > 1. Rebase the patch to current GIT head. Done. > > 2. + * Construct symlink file > > + */ > > + initStringInfo(&symlinkfbuf); > > I think declaration and initialization of symlinkfbuf string can be moved under #ifdef WIN32 compile time macro, > > for other platform it’s simply allocated and freed which can be avoided. Agreed, I have changed the patch as per your suggestion. > > 3. + /* > > + * native windows utilites are not able create symlinks while > > + * extracting files from tar. > > + */ > > > > Rephrase the above sentence and fix spelling mistake (utilities are not able to create) Done. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
extend_basebackup_to_include_symlink_v2.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
