Alvaro Herrera <alvhe...@2ndquadrant.com> writes:
> Agreed. I am going over this patch, and the last bit I need to sort out
> is the wording of these messages. I have temporarily settled on this:
> ereport(ERROR,
> (errcode(ERRCODE_INVALID_TABLE_DEFINITION),
> errmsg("cannot change logged status of table %s to
> logged",
> RelationGetRelationName(rel)),
> errdetail("Table %s references unlogged table %s.",
> RelationGetRelationName(rel),
> RelationGetRelationName(relfk))));
> Note the term "logged status" to talk about whether a table is logged or
> not. I thought about "loggedness" but I'm not sure english speakers are
> going to love me for that. Any other ideas there?
Just say "cannot change status of table %s to logged".
> Yeah, there is precedent for silently doing nothing. We previously
> threw warnings or notices, but nowadays even that is gone. Throwing an
> error definitely seems the wrong thing.
Agreed, just do nothing if it's already the right setting.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
