Michael Paquier wrote: > This remark is just to limit the amount of trash in the database used > for regression tests. But then if we'd remove everything we would lack > handy material for tests on utilities like database-wide thingies of > the type VACUUM, REINDEX, pg_dump, etc. And we can just drop the > database used for regressions to clean up everything. So that's not > mandatory at all. I tend to always clean up objects in my patches > touching regressions to limit interactions with other tests, but I > guess that's up to the person who wrote the code to decide.
Leaving lingering objects is not a bad thing, particularly if they have unusual properties; they enable somebody pg_dump'ing the database which can be a good test for pg_dump. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
