Michael Paquier <michael.paqu...@gmail.com> writes: > The patch attached fixes pg_upgrade by putting quotes when generating > reloptions and it passes check-world. I imagine that having quotes by > default in the value of reloptions in pg_class is the price to pay for > supporting units. If this is not considered as a correct approach, > then reverting the patch would be wiser I guess.
Ugh. I'm not sure what the best solution is, but I don't think I like that one. Given that this patch broke both pg_dump and pg_upgrade, I think it should be reverted for the time being, rather than applying a hasty hack. Obviously more thought and testing is needed. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers