On Thu, Sep 25, 2014 at 7:35 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Sep 25, 2014 at 10:12 AM, Simon Riggs <si...@2ndquadrant.com> wrote: >> IMHO it is impossible to know if any of the other code is correct >> until we have a clear and stable vision of what the command is >> supposed to perform. > > +1. > >> The inner workings are less important than what the feature does. > > +1. > >> FWIW, the row available at the end of all BEFORE triggers is clearly >> the object we should be manipulating, not the original VALUES() >> clause. Otherwise this type of INSERT would behave differently from >> normal INSERTs. Which would likely violate RLS, if nothing else. > > +1.
I agree with all of this. I'm glad that my opinion on how a CONFLICTING() expression interacts with BEFORE triggers is accepted, too. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
