On Wed, Oct 8, 2014 at 10:09 AM, Andres Freund <and...@2ndquadrant.com> wrote: > On 2014-09-10 16:53:12 -0400, Robert Haas wrote: >> diff --git a/src/include/libpq/libpq.h b/src/include/libpq/libpq.h >> index 5da9d8d..0b8db42 100644 >> --- a/src/include/libpq/libpq.h >> +++ b/src/include/libpq/libpq.h >> @@ -37,6 +37,31 @@ typedef struct >> } u; >> } PQArgBlock; >> >> +typedef struct >> +{ >> + void (*comm_reset)(void); >> + int (*flush)(void); >> + int (*flush_if_writable)(void); >> + bool (*is_send_pending)(void); >> + int (*putmessage)(char msgtype, const char *s, size_t len); >> + void (*putmessage_noblock)(char msgtype, const char *s, size_t len); >> + void (*startcopyout)(void); >> + void (*endcopyout)(bool errorAbort); >> +} PQsendMethods; >> + >> +PQsendMethods *PqSendMethods; > > WRT my complaint in the other subthread, I think PQsendMethods should > just be renamed to PQcommMethods or similar. That'd, in combination with > a /* at some point we might want to add methods for receiving data here > */ looks like it'd already satisfy my complaint ;)
Well, I'm happy enough to go ahead and change that, if that's all it takes to make you happy. Is it? So far the status of these patches AIUI is: #1 - Just committed, per discussion last week. #2 - No comments, possibly because it's pretty boring. #3 - Most people seem happy with v2, modulo the above renaming request. #4 - No comments. #5 - No comments; trivial. #6 - Updated per Amit's feedback. Not sure if anyone else wants to review. Still needs docs. I'm tempted to go ahead and do the renaming you've requested here and then commit #2, #3, #4, and #5. But I'll wait if people want to review more first. #6 probably needs at least one more thorough review, and of course the documentation. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers