On Mon, Oct 13, 2014 at 11:16 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Sun, Oct 12, 2014 at 1:27 PM, Stephen Frost <sfr...@snowman.net> wrote: >> * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: >>> Sawada Masahiko wrote: >>> > Attached WIP patch adds new syntax REINEX SCHEMA which does reindexing >>> > all table of specified schema. >>> > There are syntax dose reindexing specified index, per table and per >>> > database, >>> > but we can not do reindexing per schema for now. >>> >>> It seems doubtful that there really is much use for this feature, but if >>> there is, I think a better syntax precedent is the new ALTER TABLE ALL >>> IN TABLESPACE thingy, rather than your proposed REINDEX SCHEMA. >>> Something like REINDEX TABLE ALL IN SCHEMA perhaps. >> >> Yeah, I tend to agree that we should be looking at the 'ALL IN >> TABLESPACE' and 'ALL IN SCHEMA' type of commands to keep things >> consistent. This might be an alternative for the vacuum / analyze / >> reindex database commands also.. > > Urgh. I don't have a problem with that syntax in general, but it > clashes pretty awfully with what we're already doing for REINDEX > otherwise. >
Attached patches are latest version patch. I changed syntax to REINDEX ALL IN SCHEMA, but I felt a sense of discomfort a little as Robert mentioned. Anyway, you can apply these patches in numerical order, can use REINDEX ALL IN SCHEMA feature and "-S/--schema" option in reindexdb. 000_reindex_all_in_schema_v2.patch : It contains REINDEX ALL IN SCHEMA feature 001_Add_schema_option_to_reindexdb_v1.patch : It contains reindexdb "-S/--schema" supporting Please review and comments. Regards, ------- Sawada Masahiko
000_reindex_all_in_schema_v2.patch
Description: Binary data
001_Add_schema_option_to_reindexdb_v1.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
