On Mon, Nov 17, 2014 at 10:02 AM, Fujii Masao <masao.fu...@gmail.com> wrote: > On Sat, Nov 15, 2014 at 9:10 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> Yep, sounds a good thing to do if master requested answer from the >> client in the keepalive message. Something like the patch attached >> would make the deal. > > Isn't it better to do this only when replication slot is used? Makes sense. What about a check using reportFlushPosition then? -- Michael
diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c index c6c90fb..b426cfe 100644 --- a/src/bin/pg_basebackup/receivelog.c +++ b/src/bin/pg_basebackup/receivelog.c @@ -149,6 +149,34 @@ open_walfile(XLogRecPtr startpoint, uint32 timeline, char *basedir, } /* + * Flush the current WAL file to disk and update the last WAL flush + * positions as well as the last fsync timestamp. On failure, print + * a message to stderr and return false, otherwise return true. + */ +static bool +fsync_walfile(XLogRecPtr blockpos, int64 timestamp) +{ + /* nothing to do if no WAL file open */ + if (walfile == -1) + return true; + + /* nothing to do if data has already been flushed */ + if (blockpos <= lastFlushPosition) + return true; + + if (fsync(walfile) != 0) + { + fprintf(stderr, _("%s: could not fsync file \"%s\": %s\n"), + progname, current_walfile_name, strerror(errno)); + return false; + } + + lastFlushPosition = blockpos; + last_fsync = timestamp; + return true; +} + +/* * Close the current WAL file (if open), and rename it to the correct * filename if it's complete. On failure, prints an error message to stderr * and returns false, otherwise returns true. @@ -787,21 +815,12 @@ HandleCopyStream(PGconn *conn, XLogRecPtr startpos, uint32 timeline, * If fsync_interval has elapsed since last WAL flush and we've written * some WAL data, flush them to disk. */ - if (lastFlushPosition < blockpos && - walfile != -1 && - ((fsync_interval > 0 && - feTimestampDifferenceExceeds(last_fsync, now, fsync_interval)) || - fsync_interval < 0)) + if ((fsync_interval > 0 && + feTimestampDifferenceExceeds(last_fsync, now, fsync_interval)) || + fsync_interval < 0) { - if (fsync(walfile) != 0) - { - fprintf(stderr, _("%s: could not fsync file \"%s\": %s\n"), - progname, current_walfile_name, strerror(errno)); + if (!fsync_walfile(blockpos, now)) goto error; - } - - lastFlushPosition = blockpos; - last_fsync = now; } /* @@ -999,7 +1018,6 @@ ProcessKeepaliveMsg(PGconn *conn, char *copybuf, int len, { int pos; bool replyRequested; - int64 now; /* * Parse the keepalive message, enclosed in the CopyData message. @@ -1021,7 +1039,15 @@ ProcessKeepaliveMsg(PGconn *conn, char *copybuf, int len, /* If the server requested an immediate reply, send one. */ if (replyRequested && still_sending) { - now = feGetCurrentTimestamp(); + int64 now = feGetCurrentTimestamp(); + + /* + * Flush data, so a fresh position is sent but do this only if a + * flush position needs to be reported. + */ + if (reportFlushPosition && !fsync_walfile(blockpos, now)) + return false; + if (!sendFeedback(conn, blockpos, now, false)) return false; *last_status = now;
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers