"Mikheev, Vadim" <[EMAIL PROTECTED]> writes: >> Wouldn't it work for cntxDirty to be set not by LockBuffer, but by >> XLogInsert for each buffer that is included in its argument list?
> I thought to add separate call to mark context dirty but above > should work if all callers to XLogInsert always pass all > modified buffers - please check. AFAICT it is safe. There are some places (in sequences and btree) where not all the modified buffers are explicitly listed in XLogInsert's arguments, but redo of those types of WAL records will always reinit the affected pages anyway. So we don't need to worry about forcing checkpoint to write the pages early. In general I don't think this adds any fragility to the system. A WAL record that is not set up to restore all buffers modified by the logged operation would be broken by definition, no? regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])