On Tue, Dec 2, 2014 at 5:28 PM, Peter Geoghegan <p...@heroku.com> wrote: > Attached, revised patchset makes these updates.
Whoops. Missed some obsolete comments. Here is a third commit that makes a further small modification to one comment. -- Peter Geoghegan
From 8d1aba80f95e05742047cba5bd83d8f17aa5ef37 Mon Sep 17 00:00:00 2001 From: Peter Geoghegan <p...@heroku.com> Date: Tue, 2 Dec 2014 17:42:21 -0800 Subject: [PATCH 3/3] Alter comments to reflect current naming --- src/include/utils/sortsupport.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/include/utils/sortsupport.h b/src/include/utils/sortsupport.h index 659233b..f7c73b3 100644 --- a/src/include/utils/sortsupport.h +++ b/src/include/utils/sortsupport.h @@ -127,9 +127,9 @@ typedef struct SortSupportData * Returning zero from the alternative comparator does not indicate * equality, as with a conventional support routine 1, though -- it * indicates that it wasn't possible to determine how the two abbreviated - * values compared. A proper comparison, using "auth_comparator"/ - * ApplySortComparatorFull() is therefore required. In many cases this - * results in most or all comparisons only using the cheap alternative + * values compared. A proper comparison, using "abbrev_full_comparator"/ + * ApplySortAbbrevFullComparator() is therefore required. In many cases + * this results in most or all comparisons only using the cheap alternative * comparison func, which is typically implemented as code that compiles to * just a few CPU instructions. CPU cache miss penalties are expensive; to * get good overall performance, sort infrastructure must heavily weigh -- 1.9.1
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
