On Mon, Dec 8, 2014 at 12:43:36PM -0500, Robert Haas wrote: > On Sat, Dec 6, 2014 at 10:43 PM, Bruce Momjian <br...@momjian.us> wrote: > > This causes creation DDL is checked if it is used in the regression > > database, but what about ALTER and DROP? pg_dump doesn't issue those, > > except in special cases like inheritance. > > The proposed testing mechanism should cover any ALTER commands that > are in the regression tests provided that those objects are not > subsequently dropped -- because if the ALTER commands aren't replayed > properly, then the later pg_dump won't produce the same output. > > There probably are some gaps in our current regression tests in this > area, but that's probably a good thing to fix regardless of this.
OK, I understand now that the ALTERs are being passed to the slave and we then can test that against pg_dump --- sounds good. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
