On Wed, Dec 10, 2014 at 10:32:42AM +0200, Heikki Linnakangas wrote: > >I don't think we need to have 2PC files survive a pg_upgrade. It seems > >perfectly okay to remove them from the new cluster at some appropriate > >time, *if* they are copied from the old cluster at all (I don't think > >they should be.) > > I think pg_upgrade should check if there are any prepared > transactions pending, and refuse to upgrade if there are. It could > be made to work, but it's really not worth the trouble. If there are > any pending prepared transactions in the system when you run > pg_upgrade, it's more likely to be a mistake or oversight in the > first place, than on purpose.
pg_upgrade already checks for prepared transactions and errors out if they exist; see check_for_prepared_transactions(). -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
