On 16/12/14 08:43, Jaime Casanova wrote:
On Wed, Dec 10, 2014 at 6:24 PM, Petr Jelinek <p...@2ndquadrant.com> wrote:
Hello,

Attached is a basic implementation of TABLESAMPLE clause. It's SQL standard
clause and couple of people tried to submit it before so I think I don't
need to explain in length what it does - basically returns "random" sample
of a table using a specified sampling method.


Tablesample, yay!

Sadly when the jsonb functions patch was committed a few oids where
used, so you should update the ones you are using. at least to make
the patch easier for testing.

Will do.


The test added for this failed, attached is the diff. i didn't looked
up why it failed


It isn't immediately obvious to me why, will look into it.


Finally, i created a view with a tablesample clause. i used the view
and the tablesample worked, then dumped and restored and the
tablesample clause went away... actually pg_get_viewdef() didn't see
it at all.


Yeah, as I mentioned in the submission the ruleutils support is not there yet, so that's expected.

will look at the patch more close tomorrow when my brain wake up ;)


Thanks!



--
 Petr Jelinek                  http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to