On 16 December 2014 at 14:25, Heikki Linnakangas <hlinnakan...@vmware.com> wrote: > On 12/15/2014 08:54 PM, Simon Riggs wrote: >> >> Currently, it doesn't. >> >> This patch is a WIP version of doing that, but only currently attempts >> to do this in the WALSender. >> >> Objective is to allow cascaded logical replication. >> >> Very WIP, but here for comments. > > > With the patch, XLogSendLogical uses the same logic to calculate SendRqstPtr > that XLogSendPhysical does. It would be good to refactor that into a common > function, rather than copy-paste.
Some of the logic is similar, but not all. > SendRqstPtr isn't actually used for anything in XLogSendLogical. It exists to allow the call which resets TLI. I'll see if I can make it exactly identical; I didn't think so when I first looked, will look again. Thanks -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
