The fact that the ROLE_ATTR_* definitions are in pg_authid.h means that there are now a lot of files that need to include that one. I think the includes relative to ACLs and roles is rather messy now, and this patch makes it a bit worse.
I think we should create a new header file (maybe acltypes.h or acldefs.h), which only contains the AclMode and RoleAttr typedefs and their associated defines; that one would be included from parsenodes.h, acl.h and pg_authid.h. Everything else would be in acl.h. So code that currently checks permissions using only acl.h do not need any extra includes. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
