Tomas Vondra wrote: > I'm not objecting to prototypes in general, but I believe the principle > is to respect how the existing code is written. There are almost no > other prototypes in pgbench.c - e.g. there are no prototypes for > executeStatement(), init() etc. so adding the prototypes in this patch > seems inconsistent. But maybe that's nitpicking.
Well, given that Tatsuo-san invented pgbench in the first place, I think he has enough authority to decide whether to add prototypes or not. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
