>>>>> "Robert" == Robert Haas <robertmh...@gmail.com> writes:
Robert> All right, it seems Tom is with you on that point, so after Robert> some study, I've committed this with very minor modifications. This caught my eye (thanks to conflict with GS patch): * In the future, we should consider forcing the * tuplesort_begin_heap() case when the abbreviated key * optimization can thereby be used, even when numInputs is 1. The comment in tuplesort_begin_datum that abbreviation can't be used seems wrong to me; why is the copy of the original value pointed to by stup->tuple (in the case of by-reference types, and abbreviation is obviously not needed for by-value types) not sufficient? Or what am I missing? -- Andrew (irc:RhodiumToad) -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
