On 02/13/2015 07:34 PM, Jim Nasby wrote:
On 2/13/15 7:26 AM, Heikki Linnakangas wrote:
In the "redesign checkpoint_segments" patch, Robert suggested keeping
the settings' base unit as "number of segments", but allow conversions
from MB, GB etc. I started looking into that and found that adding a new
unit to guc.c is quite messy. The conversions are done with complicated
if-switch-case constructs.
Attached is a patch to refactor that, making the conversions
table-driven. This doesn't change functionality, it just makes the code
nicer.
Looks good, but shouldn't there be a check for a unit that's neither
memory or time?
Can you elaborate? We currently only support units for memory and time
settings.
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
