Hi all,

While looking at the patch to fix pg_dump with extensions containing tables
referencing each other, I got surprised by the fact that getTableAttrs
tries to dump table attributes even for tables that are part of an
extension. Is that normal?
Attached is a patch that I think makes things right, but not dumping any
tables that are part of ext_member.

Thoughts?

Regards,
-- 
Michael
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 7e92b74..2c9356b 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -6657,6 +6657,10 @@ getTableAttrs(Archive *fout, DumpOptions *dopt, TableInfo *tblinfo, int numTable
 		if (!tbinfo->interesting)
 			continue;
 
+		/* Ignore tables part of an extension */
+		if (tbinfo->dobj.ext_member)
+			continue;
+
 		/*
 		 * Make sure we are in proper schema for this table; this allows
 		 * correct retrieval of formatted type names and default exprs
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to