On 2015-02-17 15:41:45 +0200, Oskari Saarenmaa wrote: > 15.01.2015, 21:58, Robert Haas kirjoitti: > > On Wed, Jan 14, 2015 at 5:54 PM, Andres Freund <and...@2ndquadrant.com> > > wrote: > >> I think I'd for now simply not define pg_attribute_aligned() on > >> platforms where it's not supported, instead of defining it empty. If we > >> need a softer variant we can name it pg_attribute_aligned_if_possible or > >> something. > >> > >> Sounds sane? > > > > Yes, that sounds like a much better plan. > > Attached an updated patch rebased on today's git master that never > defines aligned or packed empty.
Cool, that looks good. Besides allowing other compilers to use the __attribute__ stuff, it also seems like a readability win to me. Especially the various printf stuff looks much better to me this way. I guess you've tested this on solaris and x86 linux? Greetings, Andres Freund -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
