On Fri, Feb 20, 2015 at 12:59 AM, Noah Misch <n...@leadboat.com> wrote: > On Mon, Feb 02, 2015 at 03:48:33PM -0500, Robert Haas wrote: >> On Sat, Jan 31, 2015 at 8:28 AM, Marco Nenciarini >> <marco.nenciar...@2ndquadrant.it> wrote: >> > I've attached a new version of the patch fixing the missing closedir on >> > readdir error. >> >> If readir() fails and closedir() succeeds, the return will be -1 but >> errno will be 0. > > Out of curiosity, have you seen a closedir() implementation behave that way? > It would violate C99 ("The value of errno is zero at program startup, but is > never set to zero by any library function.") and POSIX.
No. Good point, I didn't think about that. I think this way is safer, though. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers