Hi, I found a trivial typo in backend/replication/README | Walreceiver IPC | --------------- | | When the WAL replay in startup process has reached the end of archived WAL, | recoverable using recovery_command, it starts up the walreceiver process
I think the recovery_command should be restore_command. This was introduced at 9.0dev and all of REL9_x_STABLE contain this. I don't know how "recoverable using restore_command" looks wired, but I changed the sentsnce to fit the parameter name. Likewise, the release note for 8.3.2 at HEAD@master contains the similar typo. The typo originates in 8.4dev and back patched to 8.3.2 but I suspect that the all branches originates from 8.4dev need to be fixed. Patch 1: Fix for replication/README@@master Patch 2: Fix for release-8.3.sgml@master regards, -- Kyotaro Horiguchi NTT Open Source Software Center
>From 5966f29df24abed7609e8afa7a1ce906286dbf63 Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi <horiguchi.kyot...@lab.ntt.co.jp> Date: Tue, 24 Feb 2015 11:06:37 +0900 Subject: [PATCH 1/2] Fix typo of restore_command in backend/replication/README --- src/backend/replication/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/replication/README b/src/backend/replication/README index 2f5df49..8e5bf0d 100644 --- a/src/backend/replication/README +++ b/src/backend/replication/README @@ -42,7 +42,7 @@ Walreceiver IPC --------------- When the WAL replay in startup process has reached the end of archived WAL, -recoverable using recovery_command, it starts up the walreceiver process +restorable using restore_command, it starts up the walreceiver process to fetch more WAL (if streaming replication is configured). Walreceiver is a postmaster subprocess, so the startup process can't fork it -- 2.1.0.GIT
>From 69cfa3d09c4d4ffdb7136707a2348ea912fc9759 Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi <horiguchi.kyot...@lab.ntt.co.jp> Date: Tue, 24 Feb 2015 11:07:52 +0900 Subject: [PATCH 2/2] Fix typo of restore_command in release-8.3.sgml. --- doc/src/sgml/release-8.3.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/release-8.3.sgml b/doc/src/sgml/release-8.3.sgml index 3ce96f1..05d6b9b 100644 --- a/doc/src/sgml/release-8.3.sgml +++ b/doc/src/sgml/release-8.3.sgml @@ -5303,7 +5303,7 @@ <listitem> <para> Fix incorrect archive truncation point calculation for the - <literal>%r</> macro in <varname>recovery_command</> parameters + <literal>%r</> macro in <varname>restore_command</> parameter (Simon) </para> -- 2.1.0.GIT
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers