On Wed, Feb 25, 2015 at 10:30 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote:
> Michael Paquier wrote: > > On Tue, Feb 24, 2015 at 11:55 PM, Alvaro Herrera < > alvhe...@2ndquadrant.com> > > wrote: > > > > Maybe something in src/test/modules could keep these files so that > > > pg_dump can be tested. Is anybody interested in doing that? > > > > For the patch to fix data dump of extensions that contain tables with FK > I > > have implemented a test case in src/test/modules as I didn't want to look > > at postgis stuff to reproduce the failure, last version is here: > > > http://www.postgresql.org/message-id/cab7npqqrjhhmnmcgb0ecvz2ptmncmfd+1htlooxrqjmzgts...@mail.gmail.com > > That looks interesting -- I don't recall seeing it. Does it support > more doing than one extension? If so, we could certainly integrate it. > It uses TAP tests to kick pg_dump commands, and I haven't added any logic for having more than one extension installed within a single test if that is what you mean, but I assume that we could pass to prove_check a variable able to install multiple paths and install their content. For now though what I have done is adding one line to prove_check to install the content of current directory to be able to run TAP tests with one extension. -- Michael
