On 12 March 2015 at 21:28, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> I took a look at this patch today and noticed that it incorporates not >> only documentation for the new functionality it adds, but also for the >> custom-scan functionality whose documentation I previously excluded >> from commit on the grounds that it needed more work, especially to >> improve the English. That decision was not popular at the time, and I >> think we need to remedy it before going further with this. I had >> hoped that someone else would care about this work enough to help with >> the documentation, but it seems not, so today I went through the >> documentation in this patch, excluded all of the stuff specific to >> custom joins, and heavily edited the rest. The result is attached. > > Looks good; I noticed one trivial typo --- please s/returns/return/ under > ExecCustomScan. Also, perhaps instead of just "set ps_ResultTupleSlot" > that should say "fill ps_ResultTupleSlot with the next tuple in the > current scan direction".
Also: s/initalization/initialization/ -- Thom -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
