>>>>> "Tom" == Tom Lane <t...@sss.pgh.pa.us> writes:
Michael> Well, my point is to have something on which you can directly Michael> apply maths on without changing its shape ;) >> There's this trick: >> # if version < 9.1 ... >> ifeq ($(filter-out 7.% 8.% 9.0, $(MAJORVERSION)),) >> # stuff >> endif >> # if version >= 9.3 >> ifneq ($(filter-out 7.% 8.% 9.0 9.1 9.2, $(MAJORVERSION)),) >> # stuff >> endif Tom> That's pretty ugly :-(. Yes. Though shelling out to invoke "test" is ugly in different ways, even without using perl and regexps as well. Tom> I concur with Michael that there's value in exposing the version Tom> number in the numeric form used by PG_VERSION_NUM. However, I Tom> also concur with Andrew that if the use-case for this is Tom> Makefiles, pg_config is a pretty poor transmission mechanism. We Tom> should instead add PG_VERSION_NUM to the version variables set in Tom> Makefile.global. I think there's an argument for both. pg_config already has a VERSION= string in the output, and I think adding a VERSION_NUM= would be good for consistency there. And people definitely do want to do version comparisons in makefiles... -- Andrew (irc:RhodiumToad) -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
