On Tue, Mar 24, 2015 at 10:35:10PM -0400, Bruce Momjian wrote: > On Tue, Mar 24, 2015 at 10:02:03PM -0400, Tom Lane wrote: > > Bruce Momjian <br...@momjian.us> writes: > > > btree_gin: properly call DirectFunctionCall1() > > > Previously we called DirectFunctionCall3() with dummy arguments. > > > > This patch is entirely wrong and has broken the buildfarm. > > Please revert. > > OK, done.
OK, I figured out that I was only supposed to change inet_in, not the other calls to DirectFunctionCall3 (varbit_in and bit_in). Patch attached. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. +
diff --git a/contrib/btree_gin/btree_gin.c b/contrib/btree_gin/btree_gin.c new file mode 100644 index 80521fb..1a5bb3c *** a/contrib/btree_gin/btree_gin.c --- b/contrib/btree_gin/btree_gin.c *************** GIN_SUPPORT(macaddr, false, leftmostvalu *** 318,327 **** static Datum leftmostvalue_inet(void) { ! return DirectFunctionCall3(inet_in, ! CStringGetDatum("0.0.0.0/0"), ! ObjectIdGetDatum(0), ! Int32GetDatum(-1)); } GIN_SUPPORT(inet, true, leftmostvalue_inet, network_cmp) --- 318,324 ---- static Datum leftmostvalue_inet(void) { ! return DirectFunctionCall1(inet_in, CStringGetDatum("0.0.0.0/0")); } GIN_SUPPORT(inet, true, leftmostvalue_inet, network_cmp)
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers