At 2015-04-03 00:33:10 +0300, hlinn...@iki.fi wrote:
>
> I came up with the attached.

I like it very much.

src/port/Makefile has (note src/srv):

    +# pg_crc32c_sse42.o and its _src.o version need CFLAGS_SSE42
    +pg_crc32c_sse42.o: CFLAGS+=$(CFLAGS_SSE42)
    +pg_crc32c_sse42_srv.o: CFLAGS+=$(CFLAGS_SSE42)

Other than that, this looks great. Thank you.

> BTW, we might want to move the "traditional" and "legacy" crc32
> implementations out of src/common. They are only used in backend
> code now.

I agree.

-- Abhijit


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to