On Fri, Apr 3, 2015 at 9:57 PM, Fujii Masao <masao.fu...@gmail.com> wrote: > On Fri, Apr 3, 2015 at 8:37 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> On Fri, Apr 3, 2015 at 6:35 PM, Fujii Masao wrote: >>> Regarding the second patch, you added the checks of the return value of >>> XLogReaderAllocate(). But it seems half-baked. XLogReaderAllocate() still >>> uses palloc(), but don't we need to replace it with palloc_extended(), too? >> >> Doh, you are right. I missed three places. Attached is a new patch >> completing the fix. > > Thanks for the patch! I updated two source code comments and > changed the log message when XLogReaderAllocate returns NULL > within XLOG_DEBUG block. Just pushed.
Yes, thanks. This looks good as is. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
