Hi all,
I noticed two things while looking at the SSL test suite: 1) When running the tests, some logs are generated in client-log, but this log file has no entry in .gitignore... A patch is attached. 2) cp is used with a wildcard and system_or_bail in ServerSetup.pm: system_or_bail "cp ssl/server-*.crt '$tempdir'/pgdata"; system_or_bail "cp ssl/server-*.key '$tempdir'/pgdata"; system_or_bail "chmod 0600 '$tempdir'/pgdata/server-*.key"; system_or_bail "cp ssl/root+client_ca.crt '$tempdir'/pgdata"; system_or_bail "cp ssl/root+client.crl '$tempdir'/pgdata"; This does not look very portable to me. Wouldn't it be better to use glob to get a list of the files and then copy each matching entry? Thoughts? -- Michael
diff --git a/src/test/ssl/.gitignore b/src/test/ssl/.gitignore new file mode 100644 index 0000000..3bc46b5 --- /dev/null +++ b/src/test/ssl/.gitignore @@ -0,0 +1,2 @@ +# Generated by tests +/client-log
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
