On 04/15/2015 10:51 AM, Andrew Dunstan wrote:
On 04/15/2015 08:31 AM, Michael Paquier wrote:
On Wed, Apr 15, 2015 at 7:54 PM, Peter Eisentraut <pete...@gmx.net>
wrote:
On 4/14/15 8:32 PM, Peter Eisentraut wrote:
Move pg_upgrade from contrib/ to src/bin/
Oh dear. It appears the buildfarm client code needs to be updated to
support this. How do we do this? (I guess the critters that are
still
green are not running this test.)
Argh..
Looking at the buildfarm client code
(https://github.com/PGBuildFarm/client-code) we are going to need to
make the logic of TestUpgrade.pm aware that pg_upgrade is now in
src/bin and not in contrib. A simple idea would be to use a Find to
guess where pg_upgrade oath is located and then use the path found
instead of hardcoding contrib/.
I'm testing a fix. I just happened to check the status this morning.
It would have been nice to have had a heads up. The Find idea is cute,
I might have used it if I hadn't already coded a fix.
OK, the fix is here:
<https://github.com/PGBuildFarm/client-code/commit/47b24efa758360699413640dd14c4096e1643fb2>
and the new TestUpgrade.pm can be grabbed from here:
<https://raw.githubusercontent.com/PGBuildFarm/client-code/47b24efa758360699413640dd14c4096e1643fb2/PGBuild/Modules/TestUpgrade.pm>
It can just be dropped into place as a hot fix.
We're overdue for a buildfarm client release, but this hot fix should
get things green again.
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
