Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > I think the code is OK, but yeah, this comment should be changed to > > reflect the idea that the function will append entries to an existing > > list of name/value pairs (and thus, that head_p/tail_p are not output > > but in/out parameters). > > I've pushed a fix for the comment to address this.
This open-coded list thingy is pretty odd. I wonder if it'd be nicer to replace it with ilist. (Not for 9.5, of course.) -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
